Temporarily remove gRPC PHP extension from build due to slow installation and large binaries#32
Open
ma-04 wants to merge 1 commit intoflywp:mainfrom
Open
Temporarily remove gRPC PHP extension from build due to slow installation and large binaries#32ma-04 wants to merge 1 commit intoflywp:mainfrom
ma-04 wants to merge 1 commit intoflywp:mainfrom
Conversation
WalkthroughA blank line is added after the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gRPC PHP extension is currently causing significant delays during the build process. Installing the extension via
pecl install grpctakes a long time and produces very large binaries, which negatively impacts CI build times.Several upstream issues indicate that this is a known problem with the gRPC PHP extension build process.
Details;
https://github.com/ma-04/flywp-dockerfiles/actions/runs/23083888353/job/67057476647
References
pecl installis still slow and still produces massive binaries grpc/grpc#34278Problem
install-php-extensions install grpcsignificantly increases CI build time.Temporary Solution
This PR removes the gRPC PHP extension from the build to avoid the slow installation during CI.
Future Improvements
We can reintroduce gRPC once we implement one of the following:
pkg-config/with-grpc-dirsupport once it becomes stable upstreamImpact
Notes
If gRPC functionality becomes required in the future, we should revisit this and implement a proper caching or prebuilt extension strategy.
Fixes; https://github.com/flywp/issues/issues/435
Summary by CodeRabbit
Note: This release contains no functional changes or new features visible to end-users.