-
Notifications
You must be signed in to change notification settings - Fork 29
Extend copy operations with tarball extraction capabilities #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend copy operations with tarball extraction capabilities #302
Conversation
a8d5df4 to
3c98b14
Compare
|
**For initial comments. Going to do some further testing on the original operations for merge/overwrite strategies incase the change of globing has impacted them. Unit tests run but probably needs a better look. ** |
3c98b14 to
18982d4
Compare
|
Tested with previous Copy operations. Resulted that I needed to change the Glob function depending on the strategy. fs.Glob for Overwrite/Merge std files and doublestar.Glob for tarballs. With Extract strategy we don't need to walk the tree |
stefanprodan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @chris-morandi 🥇
matheuscscp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Just a few nits
18982d4 to
a311ad9
Compare
|
Can you please amend the commit message to match the PR title? |
a311ad9 to
21de6ec
Compare
|
Seems a garbage collection test is failing. Not seeing this locally. I'll have a look later. |
The tests seem to have ran fine in CI, looks like you just missed regenerating the CRD YAML after changing the struct comment: https://github.com/fluxcd/source-watcher/actions/runs/20846092767/job/59890249872?pr=302 |
Signed-off-by: Chris Morandi <chris.morandi@velocitaconsultancy.uk>
21de6ec to
b3f059c
Compare
|
Yeap fixed that. Yeah dunno what happened with test. |
Update generator Builder to support Extraction of tarball archives
Assumptions made
Fixes #301
Changes
Testing (other than unit testing)