Run post-rollout hooks when skipAnalysis is true#1918
Open
singhvishalkr wants to merge 1 commit into
Open
Conversation
When skipAnalysis is enabled and the canary is promoted, the post-rollout webhooks were not being executed. This fix ensures that runPostRolloutHooks is called in shouldSkipAnalysis, matching the behavior of the normal promotion path. Fixes fluxcd#1195 Signed-off-by: Vishal Kumar Singh <vishal.kr.singh2021@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
skipAnalysis: trueis configured, the canary promotion completes but post-rollout webhooks are never executed. I hit this while setting up a deployment notification pipeline.The issue is in
shouldSkipAnalysis- it copies the canary spec to primary, marks the canary as succeeded, but then returns without callingrunPostRolloutHooks. The normal promotion path in the finalising phase (line 414) does call it.The fix adds a single line to call
runPostRolloutHooksbefore the success message is logged. I also updated the skip-analysis test case inevents_test.goto verify the post-rollout webhook now fires.Fixes #1195