Add additionalVolumeMounts support for flagger chart#1880
Open
nedal87 wants to merge 1 commit intofluxcd:mainfrom
Open
Add additionalVolumeMounts support for flagger chart#1880nedal87 wants to merge 1 commit intofluxcd:mainfrom
nedal87 wants to merge 1 commit intofluxcd:mainfrom
Conversation
Signed-off-by: Nedal Eskaf <nedaleskaif87@gmail.com> use list default for additionalVolumes Signed-off-by: Nedal Eskaf <nedaleskaif87@gmail.com> document additionalVolumes in chart readme Signed-off-by: Nedal Eskaf <nedaleskaif87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
additionalVolumeMountssupport to the Flagger Helm chart so users can mount custom files (for example CA bundles or config files) into the Flagger container directly through chart values.This removes the need for post-render patches (such as Kustomize overlays) for a common customization pattern.
What Changed
additionalVolumeMounts: []tocharts/flagger/values.yamladditionalVolumesdefault to[]incharts/flagger/values.yamlfor type consistency with Kubernetesspec.volumescharts/flagger/templates/deployment.yaml:volumes:is rendered when eithercontrolplane.kubeconfig.secretNameoradditionalVolumesis setvolumeMounts:is rendered when eithercontrolplane.kubeconfig.secretNameoradditionalVolumeMountsis setadditionalVolumesandadditionalVolumeMountsincharts/flagger/README.mdWhy
Users already have
additionalVolumes, but there is no matching way to mount those volumes into the Flagger container from Helm values alone.This change closes that gap and makes chart-based customization simpler and more complete while preserving backward compatibility. It also complements PR #1393, which originally added
additionalVolumes.Compatibility
additionalVolumesnow uses a list default ([]), aligned with Kubernetesvolumesschema