Skip to content

warn when mesh provider isn't valid#1874

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
mtfurlan:fix/mesh-router-warn-unknown
Feb 27, 2026
Merged

warn when mesh provider isn't valid#1874
aryan9600 merged 1 commit intofluxcd:mainfrom
mtfurlan:fix/mesh-router-warn-unknown

Conversation

@mtfurlan
Copy link
Contributor

fixes #1872

Signed-off-by: Mara Furland mara@fur.land

fixes fluxcd#1872

Signed-off-by: Mara Furland <mara@fur.land>
@mtfurlan mtfurlan force-pushed the fix/mesh-router-warn-unknown branch from 6406274 to fd26b14 Compare February 20, 2026 16:41
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.00%. Comparing base (12ee6cb) to head (fd26b14).
⚠️ Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
pkg/metrics/providers/factory.go 0.00% 4 Missing ⚠️
pkg/canary/factory.go 0.00% 2 Missing ⚠️
pkg/router/factory.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
- Coverage   39.44%   30.00%   -9.44%     
==========================================
  Files         287      287              
  Lines       22706    18467    -4239     
==========================================
- Hits         8956     5541    -3415     
+ Misses      12777    12195     -582     
+ Partials      973      731     -242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aryan9600 aryan9600 merged commit 6b7c86b into fluxcd:main Feb 27, 2026
18 of 19 checks passed
@mtfurlan mtfurlan deleted the fix/mesh-router-warn-unknown branch February 27, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flagger should not silently pick a default mesh router if the requested one doesn't match

3 participants