refactor: use a pointer for field skipAnalysis in Canary object#1661
Open
Wenliang-CHEN wants to merge 1 commit into
Open
refactor: use a pointer for field skipAnalysis in Canary object#1661Wenliang-CHEN wants to merge 1 commit into
Wenliang-CHEN wants to merge 1 commit into
Conversation
This refactor tries to fulfil a special use case fluxcd#1660: when a custom controller uses the Flagger API to render the Canary object to json/yaml, it makes sure the skipAnalysis field is rendered when the value is "false", so that the field is always communicated to the k8s API server. Comparison is as follows: before, when skipAnalysis is "false" the canary object is rendered as such: ``` apiVersion: flagger.app/v1beta1 kind: Canary ... spec: analysis: ... ``` After, it is as such: ``` apiVersion: flagger.app/v1beta1 kind: Canary ... spec: skipAnalysis: false # this is the field we expected analysis: ... ```
Author
|
Hey all, I noticed that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor tries to fulfil a special use case #1660 : when a custom
controller uses the Flagger API to render the Canary object to
json/yaml, it makes sure the skipAnalysis field is rendered when the
value is "false", so that the field is always communicated to the k8s
API server.
Comparison after marshalling the Canary object to yaml is as follows:
before, when skipAnalysis is "false", the canary object is rendered as such:
After, it is as such: