Tweak pkg-config setup to work with Autotools-based project#59
Open
ilumsden wants to merge 4 commits intoflux-framework:mainfrom
Open
Tweak pkg-config setup to work with Autotools-based project#59ilumsden wants to merge 4 commits intoflux-framework:mainfrom
ilumsden wants to merge 4 commits intoflux-framework:mainfrom
Conversation
ab02ef8 to
6ba7525
Compare
…approach for using PerfFlow
6ba7525 to
ac169eb
Compare
slabasan
previously approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #50
This PR tweaks the pkg-config stuff for PerfFlow Aspect to allow an Autotools-based project (i.e., DYAD) to correctly load the C/C++ interface for PerfFlow. In particular, this PR does the following:
libperfflow_parser.soto the build. Note that this static library is not installedLibsentry ofperfflowaspect.pc-lssland-lcryptoto theLibsentry ofperfflowaspect.pcto prevent undefined symbol errors onSHA1Cflagsentry ofperfflowaspect.pcweavepassentry toperfflowaspect.pc. This entry's value is the path tolibWeavePass.soAdditionally, in DYAD, I created the following m4 macro to actually load all the info from
pkg-configinto the Autotools-based build system:In DYAD, this is put into
config/ax_perfflow_aspect.m4. This file is not included in this PR, but I can include it if desired.