feat: Flutter 3.44.0 engine upgrade + engine patch infrastructure#12
Closed
DenisovAV wants to merge 4 commits into
Closed
feat: Flutter 3.44.0 engine upgrade + engine patch infrastructure#12DenisovAV wants to merge 4 commits into
DenisovAV wants to merge 4 commits into
Conversation
Update pinned versions (flutter SHA 559ffa3f, engine v1.0.0-flutter3.44.0), fix BuildCommand breaking changes (11 new required params in 3.44.0), bump flutter_tvos to 1.0.5, update docs and changelogs.
Add reproducible tvOS engine build system to eliminate dependency on the MAUstaoglu/flutter_upstream_tvos_engine fork. Includes: - engine/build.sh: gclient sync + patch + build all 6 variants + package + publish - engine/gclient_config.py: generates .gclient for a given flutter SHA - engine/generate_patches.sh: captures diffs from a built workspace into numbered patches - engine/flutter3.44.0/: 15 patches + 7 new tvOS source files for Flutter 3.44.0 - engine/flutter3.41.9/: archived patches for Flutter 3.41.9 - .github/workflows/engine-build.yml: self-hosted workflow_dispatch CI trigger
- Pass -allowProvisioningUpdates to xcodebuild for device builds so the CLI can provision the device automatically on first run - Fix Team ID in example project.pbxproj (866PPL96Z4 → 2U7DD3DNRL) - Remove UIMainStoryboardFile from example Info.plist (not needed with programmatic entry point on tvOS)
Contributor
Author
|
Removing engine/ directory from CLI repo — will move to a separate fluttertv/engine repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
559ffa3f) and tvOS engine artifacts tov1.0.0-flutter3.44.0packages/flutter_tvosto 1.0.5engine/directory with reproducible build infrastructure for the tvOS engineEngine patch infrastructure (
engine/)The tvOS engine build process is now fully documented and reproducible inside this repo — no more relying on the
MAUstaoglu/flutter_upstream_tvos_enginefork manually.engine/build.sh— main script: gclient sync → patch → gn/ninja → package artifacts → optionalgh release createengine/generate_patches.sh— generates patches from an existing workspace after manual conflict resolutionengine/gclient_config.py—.gclienttemplate with{FLUTTER_COMMIT}placeholderengine/flutter3.44.0/— 15 patches + verbatimdarwin_ios_source/files for 3.44.0engine/flutter3.41.9/— archived patches for 3.41.9.github/workflows/engine-build.yml— manualworkflow_dispatchtrigger on self-hosted runnerDevice build fixes
-allowProvisioningUpdatesto xcodebuild for device builds (automatic signing)project.pbxproj(866PPL96Z4→2U7DD3DNRL)UIMainStoryboardFilefrom exampleInfo.plist(not needed with programmatic entry point)Test plan
dart test test/general/)flutter-tvos runon tvOS simulatorflutter-tvos run --releaseon physical Apple TV (AppleTV6,2)fluttertv/engine-artifactsasv1.0.0-flutter3.44.0