Fix redraw circle when radius changes#86
Open
enqvida wants to merge 1 commit intofluttercommunity:masterfrom
Open
Fix redraw circle when radius changes#86enqvida wants to merge 1 commit intofluttercommunity:masterfrom
enqvida wants to merge 1 commit intofluttercommunity:masterfrom
Conversation
Include circleRadius in FlutterCircle equality so radius-only updates trigger overlay replacement on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include circleRadius in FlutterCircle equality so radius-only updates trigger overlay replacement on iOS.
Root cause
The Dart layer already treats
radiusas part of circleequality and emits circle updates when only the radius
changes.
On iOS,
FlutterCircle ==did not comparecircleRadius,and
CircleController.changeCircles(...)only replacesthe overlay when the old and new circles are different.
That allows radius-only updates to be skipped.
Fix
Add
circleRadiusto the native iOS equality check forFlutterCircle.Reproduction
AppleMapwith a circle.circleId.radius.circle can stay stale.
Notes
I did not add a new automated test here because I did not
find an existing iOS overlay regression test setup for
this path.
Pre-launch Checklist
///).