Skip to content

[url_launcher] Switch to Kotlin Pigeon#11473

Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:kotlin-pigeon-url-launcher
Open

[url_launcher] Switch to Kotlin Pigeon#11473
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:kotlin-pigeon-url-launcher

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:

  • Adds Kotlin build setings to Gradle.
  • Updates API signatures for slight Kotlin/Java differences.
  • Updates tests to use constructors instead of builders, since the Kotlin generator doesn't create builders.

Part of flutter/flutter#158287

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and
adjusts the project accordingly:
- Adds Kotlin build setings to Gradle.
- Updates API signatures for slight Kotlin/Java differences.
- Updates tests to use constructors instead of builders, since the
  Kotlin generator doesn't create builders.

Part of flutter/flutter#158287
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Android implementation of the url_launcher plugin from Java to Kotlin using Pigeon v26.3.4. It updates the build configuration to include the Kotlin Gradle plugin, sets the JVM target to 17, and replaces the generated Java message classes with Kotlin equivalents. A review comment was raised regarding the use of Kotlin version 2.3.0 in the build configuration, suggesting a switch to the stable 2.0.0 release.

version = "1.0-SNAPSHOT"

buildscript {
val kotlinVersion = "2.3.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Kotlin version 2.3.0 does not appear to be a public, stable release. This could lead to build inconsistencies or issues with tooling. It's recommended to use the latest stable version, 2.0.0.

    val kotlinVersion = "2.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant