[url_launcher] Switch to Kotlin Pigeon#11473
Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Open
[url_launcher] Switch to Kotlin Pigeon#11473stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Conversation
Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly: - Adds Kotlin build setings to Gradle. - Updates API signatures for slight Kotlin/Java differences. - Updates tests to use constructors instead of builders, since the Kotlin generator doesn't create builders. Part of flutter/flutter#158287
There was a problem hiding this comment.
Code Review
This pull request migrates the Android implementation of the url_launcher plugin from Java to Kotlin using Pigeon v26.3.4. It updates the build configuration to include the Kotlin Gradle plugin, sets the JVM target to 17, and replaces the generated Java message classes with Kotlin equivalents. A review comment was raised regarding the use of Kotlin version 2.3.0 in the build configuration, suggesting a switch to the stable 2.0.0 release.
| version = "1.0-SNAPSHOT" | ||
|
|
||
| buildscript { | ||
| val kotlinVersion = "2.3.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:
Part of flutter/flutter#158287
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2