[pigeon] Make Kotlin FlutterError a runtime error#11469
[pigeon] Make Kotlin FlutterError a runtime error#11469auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Change the Kotlin generator's `FlutterError` to inherit from `RuntimException`, rather than just `Runnable`, so that it behaves as an unchecked error when used from Java (as is the case for the Java version). Fixes flutter/flutter#184200
There was a problem hiding this comment.
Code Review
This pull request updates the Pigeon generator to make generated error classes inherit from RuntimeException instead of Throwable, improving Java interoperability. The change includes updates to the Kotlin generator, platform test files, and the package version. A test case was added to verify the inheritance, and a suggestion was provided to make the test assertion more robust by specifically targeting the FlutterError class definition.
tarrinneal
left a comment
There was a problem hiding this comment.
This isn't breaking at all?
|
Change the Kotlin generator's
FlutterErrorto inherit fromRuntimeException, rather than justRunnable, so that it behaves as an unchecked error when used from Java (as is the case for the Java version).Fixes flutter/flutter#184200
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2