Handle missing playerId in buildViewWithOptions

[aesmaili]

Handle the case where buildViewWithOptions is called with a playerId that is not or no longer in the active players map. Return a Container() instead of throwing a StateError.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request adds a check to buildViewWithOptions to return an empty widget if the playerId is not present in the _players map. The review feedback suggests using SizedBox.shrink() instead of Container() for idiomatic Flutter code, optimizing the map lookup to avoid redundant calls, and adding a unit test to verify the logic change.

[gemini-code-assist]

Using const SizedBox.shrink() is preferred over Container() for returning an empty widget as it is more lightweight and idiomatic in Flutter. Additionally, this approach avoids a redundant map lookup by retrieving the player instance once and checking for null, rather than using containsKey followed by _playerWith (which performs another lookup and throws).

Suggested change

	if (!_players.containsKey(playerId)) {
	return Container();
	}
	final VideoPlayerViewState viewState = _playerWith(id: playerId).viewState;
	final _PlayerInstance? player = _players[playerId];
	if (player == null) {
	return const SizedBox.shrink();
	}
	final VideoPlayerViewState viewState = player.viewState;

References

1. Code should follow the relevant style guides (Flutter/Dart) which prefer SizedBox.shrink() for empty widgets. ^(link)

[gemini-code-assist]

This logic change should be accompanied by a unit test to verify that buildViewWithOptions correctly handles missing player IDs by returning an empty widget instead of throwing an exception. Per the repository style guide, all code changes should be tested to ensure correctness and prevent regressions.

References

1. Code should be tested. Changes to plugin packages should have appropriate tests. ^(link)

[stuartmorgan-g]

Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.