Skip to content

[camera_platform_interface] Add setJpegImageQuality method#11454

Open
Bolling88 wants to merge 3 commits intoflutter:mainfrom
Bolling88:platform-interface-jpeg-quality
Open

[camera_platform_interface] Add setJpegImageQuality method#11454
Bolling88 wants to merge 3 commits intoflutter:mainfrom
Bolling88:platform-interface-jpeg-quality

Conversation

@Bolling88
Copy link
Copy Markdown

Platform interface changes for adding JPEG compression quality control to the camera plugin. This is the platform interface subset of #11155, split out per the federated plugin contribution process.

Fixes flutter/flutter#183229

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the setJpegImageQuality method to the camera_platform_interface package, enabling control over JPEG compression quality. The update includes the interface definition, method channel implementation, and unit tests. Feedback suggests adding an assertion to validate the quality range and wrapping the method channel call in a try-catch block to throw a CameraException for consistent error handling.

@Bolling88
Copy link
Copy Markdown
Author

@bparrishMines @hellohuanlin @LouiseHsu Could you review this? It's the platform interface subset of #11155, split out per the federated plugin process.

@LouiseHsu
Copy link
Copy Markdown
Contributor

@Bolling88 I will take a look! 😸 But for future reference may I gently suggest requesting viewers through the side panel? It adds the PR to the review list, while manually tagging reviewers only generates an email that can easily get lost. :)

@LouiseHsu LouiseHsu added the CICD Run CI/CD label Apr 7, 2026
@github-actions github-actions bot removed the CICD Run CI/CD label Apr 8, 2026
@Bolling88
Copy link
Copy Markdown
Author

@Bolling88 I will take a look! 😸 But for future reference may I gently suggest requesting viewers through the side panel? It adds the PR to the review list, while manually tagging reviewers only generates an email that can easily get lost. :)

Thank you! But I think I lack the necessary permissions to add reviewers. At least that option does not exist for me when I try :(

Anyhow, we also need @bparrishMines approval before proceeding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal:[camera] Add API to control JPEG compression quality

2 participants