[camera_platform_interface] Add setJpegImageQuality method#11454
[camera_platform_interface] Add setJpegImageQuality method#11454Bolling88 wants to merge 3 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the setJpegImageQuality method to the camera_platform_interface package, enabling control over JPEG compression quality. The update includes the interface definition, method channel implementation, and unit tests. Feedback suggests adding an assertion to validate the quality range and wrapping the method channel call in a try-catch block to throw a CameraException for consistent error handling.
packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart
Show resolved
Hide resolved
|
@bparrishMines @hellohuanlin @LouiseHsu Could you review this? It's the platform interface subset of #11155, split out per the federated plugin process. |
|
@Bolling88 I will take a look! 😸 But for future reference may I gently suggest requesting viewers through the side panel? It adds the PR to the review list, while manually tagging reviewers only generates an email that can easily get lost. :) |
Thank you! But I think I lack the necessary permissions to add reviewers. At least that option does not exist for me when I try :( Anyhow, we also need @bparrishMines approval before proceeding? |
Platform interface changes for adding JPEG compression quality control to the camera plugin. This is the platform interface subset of #11155, split out per the federated plugin contribution process.
Fixes flutter/flutter#183229
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2