Skip to content

[quick_actions] Remove manual thread hop in Android response#11445

Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:quick-actions-android-thread-simplification
Open

[quick_actions] Remove manual thread hop in Android response#11445
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:quick-actions-android-thread-simplification

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Method channel replies have been thread safe for quite a while, so the old code to hop back to the main thread to send a response is no longer needed.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Method channel replies have been thread safe for quite a while, so the
old code to hop back to the main thread to send a response is no longer
needed.
@stuartmorgan-g stuartmorgan-g requested a review from jesswrd April 6, 2026 16:02
@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator Author

test-exempt: removing code

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Apr 6, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the quick_actions_android package to version 1.0.29. The changes simplify thread handling in QuickActions.java by removing the custom UiThreadExecutor and the explicit dispatch of results to the main thread within the setShortcutItems method. I have no feedback to provide.

@stuartmorgan-g stuartmorgan-g added triage-android Should be looked at in Android triage labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: quick_actions platform-android triage-android Should be looked at in Android triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant