[quick_actions] Remove manual thread hop in Android response#11445
[quick_actions] Remove manual thread hop in Android response#11445stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Conversation
Method channel replies have been thread safe for quite a while, so the old code to hop back to the main thread to send a response is no longer needed.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: removing code |
There was a problem hiding this comment.
Code Review
This pull request updates the quick_actions_android package to version 1.0.29. The changes simplify thread handling in QuickActions.java by removing the custom UiThreadExecutor and the explicit dispatch of results to the main thread within the setShortcutItems method. I have no feedback to provide.
Method channel replies have been thread safe for quite a while, so the old code to hop back to the main thread to send a response is no longer needed.
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2