Add CameraUpdate.newLatLngBoundsWithEdgeInsets (#183439)#11438
Add CameraUpdate.newLatLngBoundsWithEdgeInsets (#183439)#11438benji-farquhar wants to merge 3 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for CameraUpdate.newLatLngBoundsWithEdgeInsets across the Android, iOS, and Web implementations of the google_maps_flutter plugin. The changes include updating the platform interface, implementing the new camera update type in the platform-specific code, and adding relevant tests. A critical issue was identified in the Objective-C conversion logic where the isKindOfClass: check and type casting are incorrectly applied to the wrapper object instead of the wrapped camera update.
...flutter_ios/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/FGMConversionUtils.m
Show resolved
Hide resolved
...ios/google_maps_flutter_ios_sdk10/Sources/google_maps_flutter_ios_sdk10/FGMConversionUtils.m
Show resolved
Hide resolved
...9/ios/google_maps_flutter_ios_sdk9/Sources/google_maps_flutter_ios_sdk9/FGMConversionUtils.m
Show resolved
Hide resolved
...shared_code/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/FGMConversionUtils.m
Show resolved
Hide resolved
The issue pointed out by gemini-code-assist is a false positive. The local variable |
|
Thank you for the clarification, @benji-farquhar. I appreciate you pointing out that the |
782d0bf to
ee0334f
Compare
ee0334f to
751bbd3
Compare
…on Android (#183439)
751bbd3 to
f23a0ad
Compare
Fixes #183439