[pr-fix] Run all flutter/packages macOS tests using Xcode 26 and iOS 26 simulator#10635
[pr-fix] Run all flutter/packages macOS tests using Xcode 26 and iOS 26 simulator#10635okorohelijah wants to merge 23 commits intoflutter:mainfrom
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
|
@okorohelijah I spotted some extra analyzer warnings in the in_app_purchase failures: #10649 |
|
Dang... It does show it downloading from cipd, though I'm unsure what "Overriding runtime 23C53 with 23C54" means: |
|
@jmagman I think the first 2 errors you mentioned (found in |
|
From triage: Is this still under investigation? |
|
I think all issues have been filed and accounted for! Thank you! |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
Re-testing now that flutter/flutter#180014 is fixed. |
There was a problem hiding this comment.
Code Review
This pull request updates the CI environment to macOS 15.7 and Xcode 17e192, while upgrading iOS simulator tests to version 26.4. It enables several Mac_arm64 platform tests in presubmit and addresses iOS 26+ compatibility issues in google_maps_flutter_ios and webview_flutter_wkwebview, including warning suppression and test stability fixes. Feedback indicates that enabling these tests in presubmit contradicts an existing comment in .ci.yaml regarding test execution policy.
| @@ -886,7 +885,6 @@ targets: | |||
| # Don't run full platform tests on both channels in pre-submit. | |||
There was a problem hiding this comment.
The comment states that full platform tests should not be run on both channels in pre-submit. However, removing presubmit: false from the stable targets (e.g., lines 889, 899, 909, 919, 929 in the previous version) causes them to run in pre-submit alongside the master targets, which contradicts this policy. If the intention is to run all tests in pre-submit as suggested by the PR title, this comment should be updated or removed to reflect the new policy.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#172856
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3