[google_maps_flutter_ios] Add Advanced marker support#10508
[google_maps_flutter_ios] Add Advanced marker support#10508jokerttu wants to merge 1 commit intoflutter:mainfrom
Conversation
8f811e9 to
26fd75a
Compare
|
Picking up the discussion from the main issue here: do you have a link to the tracking issue for the blocker here ("an issue with the GMSPinImage not rendering on the map", per this comment)? As noted in that discussion, the link is to a long-closed issue. |
Added tracking issue information to this PR description: |
16c74d8 to
df35a62
Compare
f8f8a88 to
2c08201
Compare
2c08201 to
b1b0038
Compare
|
|
||
| bool? buildingsEnabled; | ||
|
|
||
| PlatformMarkerType? markerType; |
There was a problem hiding this comment.
Please make this non-nullable to avoid a repeat of flutter/flutter#182540 on iOS (and for consistency with the changes in #11061).
This PR adds Advanced markers support to the iOS implementation of
google_maps_flutter.Approved combined PR: #7882
Approved and merged platform interface PR: #9737
Issue: flutter/flutter#155526
Blocker:
GMSAdvancedMarker is not rendered when the marker icon is a GMSPinImage instance. Tracking issue:
https://issuetracker.google.com/issues/370536110
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3