[google_maps_flutter_android] Add advanced markers support#10381
[google_maps_flutter_android] Add advanced markers support#10381jokerttu wants to merge 5 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for Advanced Markers in the Android implementation of google_maps_flutter. The changes are comprehensive, including dependency updates, new logic for handling AdvancedMarkerOptions like PinConfig and collisionBehavior, and the addition of AdvancedMarkerClusterRenderer for clustering. A new API, isAdvancedMarkersAvailable, is also included. The example app has been updated with new pages to demonstrate these features. The implementation is solid and well-tested. I have a couple of minor suggestions to improve code quality and maintainability.
...r_android/android/src/main/java/io/flutter/plugins/googlemaps/ClusterManagersController.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Show resolved
Hide resolved
44e6b7a to
3cfb6f4
Compare
reidbaker
left a comment
There was a problem hiding this comment.
Java code reviewed. Sorry this took so long but thank you so much for your contribution.
...r_android/android/src/main/java/io/flutter/plugins/googlemaps/ClusterManagersController.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Show resolved
Hide resolved
...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
Outdated
Show resolved
Hide resolved
..._maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkerBuilder.java
Outdated
Show resolved
Hide resolved
..._maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkerBuilder.java
Outdated
Show resolved
Hide resolved
...droid/android/src/test/java/io/flutter/plugins/googlemaps/ClusterManagersControllerTest.java
Outdated
Show resolved
Hide resolved
...utter_android/android/src/test/java/io/flutter/plugins/googlemaps/MarkersControllerTest.java
Show resolved
Hide resolved
304d11c to
4e3e0e9
Compare
4e3e0e9 to
82fa871
Compare
|
Hi, any update on this? For context:
I just wanted to check whether anything is blocking a re-review. Please let me know if there’s anything else you need from me. |
camsim99
left a comment
There was a problem hiding this comment.
Apologies for the delay. This looks good to me! We'll just need a second review to get this landed at this point.
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Outdated
Show resolved
Hide resolved
82fa871 to
b0ab124
Compare
|
Rebased and tested locally. Waiting second review. |
|
@camsim99 Therefore I also updated new colors values for Advanced Markers to use the same mechanism on following commit: f45c208 |
|
From triage: @reidbaker did you want to review this again, or should it just be landed? We don't need a second review from a process standpoint since this is a team member PR. |
|
I don't need a second pass but can give one of you think it will help |
|
In that case @jokerttu please let us know if there's any area you would like additional review on, otherwise feel free to add the |
|
autosubmit label was removed for flutter/packages/10381, because - The status or check suite Windows_x64 repo_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
This failure is due to one of our repo tool dependencies publishing an update that broke an overly strict test; #11014 has the fix, and once that lands you'll need to merge in master again. |
This PR adds Advanced markers support to the Android implementation of google_maps_flutter.
Approved combined PR: #7882
Approved and merged platform interface PR: #9737
Issue: flutter/flutter#155526
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3