-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(ios): add audio track selection support for AVFoundation #10313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nateshmbhat
wants to merge
27
commits into
flutter:main
Choose a base branch
from
nateshmbhat:28-oct-platform-avfoundation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
459e7f8
feat(video_player_avfoundation): implement audio track selection
nateshmbhat 272ff1d
chore(video_player): bump minimum OS versions for iOS and macOS
nateshmbhat 6905f0a
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat b253fa4
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat 1bfefef
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat 32ab95d
Update packages/video_player/video_player_avfoundation/darwin/video_p…
nateshmbhat 9f13dc2
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat dcb886d
refactor(ios): remove audio selection options caching
nateshmbhat cb061e8
refactor(ios): simplify audio track metadata extraction
nateshmbhat 3c8b5d4
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat c972c37
refactor(ios): improve error handling and code formatting in video pl…
nateshmbhat aee5360
Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…
nateshmbhat 2071972
refactor(ios): replace error handling with assertions in audio track …
nateshmbhat 4d78fb2
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat b77c751
test(ios): remove redundant nil-check tests for getAudioTracks
nateshmbhat 31858c4
chore(video_player_avfoundation): bump version to 2.9.0
nateshmbhat d2f6def
Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…
nateshmbhat f17d787
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat c9e9d42
fixed lint warning
nateshmbhat 4c7c534
Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…
nateshmbhat c60befb
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat 93989eb
Format avfoundation_video_player.dart
nateshmbhat 731400a
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat 9d91faf
test: remove audio track test cases from `VideoPlayerTests.m`
nateshmbhat 4c07e9e
Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…
nateshmbhat 524223d
style: reformat `NSURL` initializations in tests and update Xcode pro…
nateshmbhat 27d5b20
Merge branch 'main' into 28-oct-platform-avfoundation
nateshmbhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "flutter": "3.38.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
|
|
||
| # FVM Version Cache | ||
| .fvm/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.