-
Notifications
You must be signed in to change notification settings - Fork 98
poc #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
polina-c
wants to merge
6
commits into
flutter:main
Choose a base branch
from
polina-c:allow-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
poc #623
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
035d546
Create prompt_builder.dart
polina-c 72605e2
Update prompt_builder.dart
polina-c a0adf9e
-
polina-c e954d11
Merge branch 'main' of github.com:flutter/genui into allow-poc
polina-c e0578a0
Merge branch 'main' of github.com:flutter/genui into allow-poc
polina-c ec7a233
-
polina-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| class ToolSet {} | ||
|
|
||
| sealed class GenUiConfiguration { | ||
| static GenUiConfiguration custom(String prompt, ToolSet toolSet) => | ||
| _CustomGenUiConfiguration(prompt, toolSet); | ||
|
|
||
| static GenUiConfiguration basic( | ||
| String prompt, { | ||
| bool allowSurfaceCreation = true, | ||
| bool allowSurfaceUpdate = false, | ||
| bool allowSurfaceDeletion = false, | ||
| }) => _BasicGenUiConfiguration( | ||
| prompt, | ||
| allowSurfaceCreation: allowSurfaceCreation, | ||
| allowSurfaceUpdate: allowSurfaceUpdate, | ||
| allowSurfaceDeletion: allowSurfaceDeletion, | ||
| ); | ||
|
|
||
| String prompt(); | ||
|
|
||
| ToolSet toolSet(); | ||
| } | ||
|
|
||
| class _CustomGenUiConfiguration implements GenUiConfiguration { | ||
| final String _prompt; | ||
| final ToolSet _toolSet; | ||
|
|
||
| _CustomGenUiConfiguration(this._prompt, this._toolSet); | ||
|
|
||
| @override | ||
| String prompt() => _prompt; | ||
|
|
||
| @override | ||
| ToolSet toolSet() => _toolSet; | ||
| } | ||
|
|
||
| class _BasicGenUiConfiguration implements GenUiConfiguration { | ||
| final String _prompt; | ||
| final bool allowSurfaceCreation; | ||
| final bool allowSurfaceUpdate; | ||
| final bool allowSurfaceDeletion; | ||
|
|
||
| _BasicGenUiConfiguration( | ||
| this._prompt, { | ||
| required this.allowSurfaceCreation, | ||
| required this.allowSurfaceUpdate, | ||
| required this.allowSurfaceDeletion, | ||
| }); | ||
|
|
||
| @override | ||
| String prompt() => throw UnimplementedError(); | ||
|
|
||
| @override | ||
| ToolSet toolSet() => throw UnimplementedError(); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
prompt()andtoolSet()methods in_BasicGenUiConfigurationcurrently throwUnimplementedError. If_BasicGenUiConfigurationis meant to be a concrete implementation, these methods should provide actual logic or sensible default values rather than throwing runtime errors. This could lead to unexpected crashes if this configuration is used.