Skip to content

Delete launched propertyEditorRefactors feature flag #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 3 commits into from
Dec 15, 2025
Merged

Delete launched propertyEditorRefactors feature flag #9579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c85651
Remove full launched property editor refactors feature flag
elliette Dec 11, 2025
8da1078
Merge branch 'master' into property-editor-refactors-feature-flag
elliette Dec 12, 2025
b42ab79
formatting
elliette Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/devtools_app/lib/src/shared/feature_flags.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,6 @@ extension FeatureFlags on Never {
enabled: true,
);

/// Flag to enable refactors in the Flutter Property Editor sidebar.
///
/// https://github.com/flutter/devtools/issues/9214
static final propertyEditorRefactors = BooleanFeatureFlag(
name: 'propertyEditorRefactors',
enabled: true,
);

/// A set of all the boolean feature flags for debugging purposes.
///
/// When adding a new boolean flag, you are responsible for adding it to this
Expand All @@ -103,7 +95,6 @@ extension FeatureFlags on Never {
devToolsExtensions,
dapDebugging,
inspectorV2,
propertyEditorRefactors,
};

/// A set of all the Flutter channel feature flags for debugging purposes.
Expand Down
4 changes: 1 addition & 3 deletions ...ools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import '../../../shared/analytics/analytics.dart' as ga;
import '../../../shared/analytics/constants.dart' as gac;
import '../../../shared/editor/api_classes.dart';
import '../../../shared/editor/editor_client.dart';
import '../../../shared/feature_flags.dart';
import '../../../shared/ui/filter.dart';
import '../../../shared/utils/utils.dart';
import 'property_editor_types.dart';
Expand Down Expand Up @@ -223,8 +222,7 @@ class PropertyEditorController extends DisposableController
CodeActionResult? refactorsResult;
// TODO(https://github.com/flutter/devtools/issues/8652): Enable refactors
// in the Property Editor by default.
if (editableArgsResult != null &&
FeatureFlags.propertyEditorRefactors.isEnabled) {
if (editableArgsResult != null) {
// Fetch the refactors using the start of the editable arguments' range,
// which corresponds to the widget constructor name. This ensures that the
// refactors are always available, even when the cursor is within the
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/test/shared/primitives/feature_flags_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ void main() {
expect(FeatureFlags.devToolsExtensions.isEnabled, isExternalBuild);
expect(FeatureFlags.dapDebugging.isEnabled, false);
expect(FeatureFlags.inspectorV2.isEnabled, true);
expect(FeatureFlags.propertyEditorRefactors.isEnabled, true);
});

group('FlutterChannelFeatureFlag', () {
Expand Down
3 changes: 0 additions & 3 deletions ...ages/devtools_app/test/standalone_ui/ide_shared/property_editor/property_editor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import 'dart:ui';
import 'package:devtools_app/devtools_app.dart';
import 'package:devtools_app/src/shared/analytics/constants.dart' as gac;
import 'package:devtools_app/src/shared/editor/api_classes.dart';
import 'package:devtools_app/src/shared/feature_flags.dart';
import 'package:devtools_app/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart';
import 'package:devtools_app/src/standalone_ui/ide_shared/property_editor/property_editor_refactors.dart';
import 'package:devtools_app/src/standalone_ui/ide_shared/property_editor/property_editor_types.dart';
Expand Down Expand Up @@ -927,8 +926,6 @@ void main() {
);

setUp(() {
FeatureFlags.propertyEditorRefactors.setEnabledForTests(true);

refactorCount = 0;
when(
// ignore: discarded_futures, for mocking purposes.
Expand Down