185700 gemini log analyzer#5037
Open
ievdokdm wants to merge 11 commits intoflutter:mainfrom
Open
Conversation
ievdokdm
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/cocoon/5037, because - The status or check suite common-validations has failed. Please fix the issues identified (or deflake) before re-applying this label. |
ievdokdm
added
autosubmit
ievdokdm
force-pushed
the
185700-gemini-log-analyzer
branch
from
bd1e1d9 to
fbf6fc6
Compare
ievdokdm
force-pushed
the
185700-gemini-log-analyzer
branch
from
fbf6fc6 to
b10a32c
Compare
ievdokdm
force-pushed
the
185700-gemini-log-analyzer
branch
from
e0a3c69 to
c1df029
Compare
Contributor
|
autosubmit label was removed for flutter/cocoon/5037, because - The status or check suite test-common-packages (dev/cocoon_code_health) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
Bot
removed
the
autosubmit
ievdokdm
force-pushed
the
185700-gemini-log-analyzer
branch
from
b6a9ec4 to
44651b4
Compare
ievdokdm
force-pushed
the
185700-gemini-log-analyzer
branch
from
44651b4 to
cfdf409
Compare
jtmcdole
requested changes
May 8, 2026
Comment on lines
+251
to
+253
| int? get buildId => fields[fieldBuildId] != null | ||
| ? int.parse(fields[fieldBuildId]!.integerValue!) | ||
| : null; |
Member
There was a problem hiding this comment.
q: Should you use int.tryParse just to avoid throwing if the field is unparsable?
you could also cheat and just do: int.tryParse(fields[fieldBuildId]?.integerValue ?? '')
|
|
||
| void updateFromBuild(bbv2.Build build) { | ||
| fields[fieldBuildNumber] = build.number.toValue(); | ||
| fields[fieldBuildId] = Value(integerValue: build.id.toString()); |
Member
There was a problem hiding this comment.
Suggested change
| fields[fieldBuildId] = Value(integerValue: build.id.toString()); | |
| fields[fieldBuildId] = build.id.toValue(); |
| final prNumber = requestData[kPrParam] as int; | ||
| final buildId = requestData[kBuildIdParam] as int; | ||
|
|
||
| final slug = RepositorySlug(owner, repo); |
Member
There was a problem hiding this comment.
Can we validate this slug is in the configured repos (there is a set in Config)? I get UnifiedCheckRun.getLatestPresubmitGuardForPrNum might also check, but it would be nice to have this explicit.
| Future<void> main() async { | ||
| final cache = CacheService(inMemory: false); | ||
| final secretManager = FakeSecretManager(); | ||
| secretManager.putString('APP_DART_GEMINI_LOG_ANALYZER_KEY', 'dummy_key'); |
Member
There was a problem hiding this comment.
you could allow someone working locally to test with their own key:
Suggested change
| secretManager.putString('APP_DART_GEMINI_LOG_ANALYZER_KEY', 'dummy_key'); | |
| secretManager.putString('APP_DART_GEMINI_LOG_ANALYZER_KEY', Platform.environment['APP_DART_GEMINI_LOG_ANALYZER_KEY'] ?? dummy_key); |
|
|
||
| @override | ||
| Future<String> get geminiLogAnalyzerKey async => | ||
| geminiLogAnalyzerKeyValue ?? 'fake-gemini-key'; |
Member
There was a problem hiding this comment.
GenKit supports web (according to pub.dev) so you could use the following. Note, this is different from Platform and is instead a dart compile option (-DAPP_DART_GEMINI_LOG_ANALYZER_KEY="$APP_DART_GEMINI_LOG_ANALYZER_KEY")
Suggested change
| geminiLogAnalyzerKeyValue ?? 'fake-gemini-key'; | |
| geminiLogAnalyzerKeyValue ?? | |
| String.fromEnvironment('APP_DART_GEMINI_LOG_ANALYZER_KEY', defaultValue: 'fake-gemini-key'); |
jtmcdole
reviewed
May 8, 2026
Member
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
My comments don't apear to have been posted. Trying again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented API for analyzing failed logs with gemini
partial implementation of: flutter/flutter#185700