Merged
Conversation
Task: Create task sorting utility Summary: Implemented compareTasks function to sort tasks by status priority and name. Files: dashboard/lib/logic/task_sorting.dart, dashboard/test/logic/task_sorting_test.dart Why: Provides the core logic for sorting presubmit checks on the dashboard.
Task: Apply sorting to _ChecksSidebar Summary: Applied compareTasks sorting logic to the builds in the checks sidebar. Files: dashboard/lib/views/presubmit_view.dart, dashboard/test/views/presubmit_view_test.dart Why: Improves visibility of failed and in-progress checks by prioritizing them at the top of each stage.
…s sorting' as complete
…implement checks sorting'
Contributor
|
🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This Pull Request successfully implements a sorting mechanism for the presubmit dashboard, prioritizing tasks by their status and then alphabetically by name. The core sorting logic is sound, well-tested, and meets the stated objectives. However, there are a few minor issues regarding unintended changes and potential performance optimizations in the UI layer.
🔍 General Feedback
- The core sorting utility
compareTasksis well-implemented and exhaustive over theTaskStatusenum. - The unit tests provided in
task_sorting_test.dartandpresubmit_view_test.dartprovide excellent coverage of the new sorting logic. - Consider reviewing the unrelated modifications in
app_dart/lib/src/service/scheduler.dartto ensure no accidental logic regressions were introduced. - Please verify the accessibility impact of the reduced padding and minimum button sizes on the dashboard's touch targets.
…ycle methods rather than during build().
ievdokdm
added
autosubmit
jtmcdole
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: flutter/flutter#183863