chore: replace npm with pnpm#1849
Merged
pedrolamas merged 17 commits intoMay 20, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
added
the
Code - Infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s tooling and contributor workflows from npm to pnpm (including CI and the devcontainer) to reduce duplicated node_modules storage and better support git worktrees.
Changes:
- Switches CI workflows and Husky hooks to use
pnpmcommands. - Updates contributor/developer documentation to instruct
pnpm+ Corepack usage. - Pins the package manager via
package.json#packageManagerand moves dependency overrides intopnpm-workspace.yaml.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds pnpm install/build allowlist and dependency overrides configuration. |
| package.json | Updates scripts to invoke pnpm and pins pnpm via packageManager; removes prior overrides block. |
| docs/docs/getting-started.md | Replaces npm commands with pnpm for building from source. |
| docs/docs/development.md | Documents enabling Corepack/pnpm and updates install/dev/test commands. |
| CONTRIBUTING.md | Updates contributor setup and CI command references to pnpm (with Corepack note). |
| AGENTS.md | Updates internal contributor guidance/commands to pnpm. |
| .husky/pre-commit | Switches eslint invocation from npx to pnpm exec. |
| .gitignore | Ignores .pnpm-store. |
| .github/workflows/release.yml | Updates release workflow to install and run checks with pnpm. |
| .github/workflows/build.yml | Updates build workflow to install and run checks with pnpm. |
| .devcontainer/Dockerfile | Enables Corepack, sets zsh, and prepares workspace dirs for pnpm/node_modules. |
| .devcontainer/docker-compose.yml | Adds named volumes for node_modules and .pnpm-store; adjusts networking/ports. |
| .devcontainer/devcontainer.json | Updates postCreateCommand to pnpm and tweaks forwarded ports/terminal settings. |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely replaces
npmwithpnpm, including in the devcontainer.The main reason is the wasted space from using
npm, especially when we are dealing with git worktrees where we get multiple "node_modules" copies -pnpmsolves this by using symbolic links instead of duplicating the files.