Skip to content

fix(security): Read-all and Write-all permissions should not be used in .github/workflows/pr-quota-limit.yml#5656

Merged
RongGu merged 1 commit intofluid-cloudnative:masterfrom
JiGuoDing:fix-branch
Feb 3, 2026
Merged

fix(security): Read-all and Write-all permissions should not be used in .github/workflows/pr-quota-limit.yml#5656
RongGu merged 1 commit intofluid-cloudnative:masterfrom
JiGuoDing:fix-branch

Conversation

@JiGuoDing
Copy link
Collaborator

Ⅰ. Describe what this PR does

This PR tries to replace permissions: read-all in .github/workflows/pr-quota-limit.yml with contents: read and pull-requests: read for security reasons.

Ⅱ. Does this pull request fix one issue?

fixes #5632

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…in .github/workflows/pr-quota-limit.yml

Signed-off-by: JiGuoDing <485204300@qq.com>
Copilot AI review requested due to automatic review settings February 2, 2026 08:14
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a security concern by replacing the overly permissive permissions: read-all directive in the PR quota limit workflow with specific, minimal permissions following the principle of least privilege. The change grants only contents: read and pull-requests: read at the workflow level, while the job itself maintains appropriate write permissions for its operations.

Changes:

  • Replaced permissions: read-all with explicit contents: read and pull-requests: read permissions in the workflow file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.35%. Comparing base (0745727) to head (b3e99bf).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5656   +/-   ##
=======================================
  Coverage   59.35%   59.35%           
=======================================
  Files         444      444           
  Lines       30540    30540           
=======================================
  Hits        18128    18128           
  Misses      10910    10910           
  Partials     1502     1502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RongGu RongGu merged commit ff0e62d into fluid-cloudnative:master Feb 3, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Read-all and Write-all permissions should not be used in .github/workflows/pr-quota-limit.yml

2 participants