test(tiredstore) : Migrate Tiredstore Ginkgo/Gomega

[yuvraj-kolkar17]

Ⅰ. Describe what this PR does

Migration of tieredstore_test.go from Go's standard testing framework to Ginkgo v2 + Gomega testing framework.

Ⅱ. Does this pull request fix one issue?

Part of #5407

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @yuvraj-kolkar17, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the testing infrastructure for the tieredstore utility by adopting the Ginkgo and Gomega frameworks. This change aims to improve the maintainability, expressiveness, and overall quality of the test suite, making it easier to understand and extend in the future. It's a foundational step towards standardizing testing practices across the codebase.

Highlights

• Testing Framework Migration: The tieredstore_test.go file has been migrated from Go's standard testing package to the Ginkgo v2 and Gomega testing framework, enhancing test structure and readability.
• New Test Suite File: A new file, tiered_store_suite_test.go, has been added to initialize the Ginkgo test suite for the tieredstore package, serving as the entry point for running these new tests.
• Refactored Test Cases: All existing test functions (TestLen, TestSwap, TestLess, TestMakeMediumTypeSorted, TestGetLevelStorageMap, TestGetTieredLevel) in tiered_store_test.go have been refactored into Ginkgo's Describe, Context, and It blocks, utilizing Gomega matchers for assertions.
• Improved Test Assertions: Error checks using t.Errorf have been replaced with more expressive Gomega Expect assertions, leading to clearer and more concise test failures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[fluid-e2e-bot]

Hi @yuvraj-kolkar17. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gemini-code-assist]

Code Review

This pull request successfully migrates the tests in tieredstore_test.go from the standard Go testing framework to Ginkgo/Gomega, which improves test readability and structure. The migration is well-executed. I've identified an opportunity to enhance the robustness of the tests for the makeMediumTypeSorted function by making the assertions more comprehensive.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.23%. Comparing base (6dd9555) to head (f303f18).
⚠️ Report is 54 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5639      +/-   ##
==========================================
+ Coverage   56.76%   59.23%   +2.46%     
==========================================
  Files         443      444       +1     
  Lines       30735    30540     -195     
==========================================
+ Hits        17447    18089     +642     
+ Misses      11734    10952     -782     
+ Partials     1554     1499      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[yuvraj-kolkar17]

/cc @cheyang @RongGu @TrafalgarZZZ