Skip to content

test(thin): migrate transform_config_test.go to Ginkgo/Gomega#5627

Open
hxrshxz wants to merge 1 commit intofluid-cloudnative:masterfrom
hxrshxz:test/migrate-thin-transform-config-test
Open

test(thin): migrate transform_config_test.go to Ginkgo/Gomega#5627
hxrshxz wants to merge 1 commit intofluid-cloudnative:masterfrom
hxrshxz:test/migrate-thin-transform-config-test

Conversation

@hxrshxz
Copy link
Contributor

@hxrshxz hxrshxz commented Jan 29, 2026

Ⅰ. Describe what this PR does

Migrates pkg/ddc/thin/transform_config_test.go from standard Go testing to the Ginkgo/Gomega framework.

Ⅱ. Does this pull request fix one issue?

part of #5407

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases added. All existing tests were migrated to Ginkgo/Gomega format.

Ⅳ. Describe how to verify it

go test ./pkg/ddc/thin/... -v

Signed-off-by: Harsh <harshmastic@gmail.com>
Copilot AI review requested due to automatic review settings January 29, 2026 02:36
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 29, 2026

Hi @hxrshxz. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates pkg/ddc/thin/transform_config_test.go from standard Go testing framework to Ginkgo/Gomega as part of the ongoing effort to standardize testing across the Fluid codebase (issue #5407).

Changes:

  • Replaced standard testing package with Ginkgo/Gomega for BDD-style testing
  • Converted TestThinEngine_extractVolumeInfo to Ginkgo structure with Describe/It/BeforeEach blocks
  • Converted TestThinEngine_extractVolumeMountOptions to DescribeTable with table-driven test entries
  • Replaced reflect.DeepEqual and t.Errorf with Gomega matchers (Expect().To(Equal()), Expect().NotTo(HaveOccurred()))

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.22%. Comparing base (2a85fb5) to head (7958e2c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5627   +/-   ##
=======================================
  Coverage   59.22%   59.22%           
=======================================
  Files         444      444           
  Lines       30431    30431           
=======================================
  Hits        18024    18024           
  Misses      10912    10912           
  Partials     1495     1495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant