test(thin): migrate transform_config_test.go to Ginkgo/Gomega#5627
test(thin): migrate transform_config_test.go to Ginkgo/Gomega#5627hxrshxz wants to merge 1 commit intofluid-cloudnative:masterfrom
Conversation
Signed-off-by: Harsh <harshmastic@gmail.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @hxrshxz. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR migrates pkg/ddc/thin/transform_config_test.go from standard Go testing framework to Ginkgo/Gomega as part of the ongoing effort to standardize testing across the Fluid codebase (issue #5407).
Changes:
- Replaced standard
testingpackage with Ginkgo/Gomega for BDD-style testing - Converted
TestThinEngine_extractVolumeInfoto Ginkgo structure withDescribe/It/BeforeEachblocks - Converted
TestThinEngine_extractVolumeMountOptionstoDescribeTablewith table-driven test entries - Replaced
reflect.DeepEqualandt.Errorfwith Gomega matchers (Expect().To(Equal()),Expect().NotTo(HaveOccurred()))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5627 +/- ##
=======================================
Coverage 59.22% 59.22%
=======================================
Files 444 444
Lines 30431 30431
=======================================
Hits 18024 18024
Misses 10912 10912
Partials 1495 1495 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Ⅰ. Describe what this PR does
Migrates
pkg/ddc/thin/transform_config_test.gofrom standard Go testing to the Ginkgo/Gomega framework.Ⅱ. Does this pull request fix one issue?
part of #5407
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
No new test cases added. All existing tests were migrated to Ginkgo/Gomega format.
Ⅳ. Describe how to verify it
go test ./pkg/ddc/thin/... -v