test(injector): refactor tests to use Ginkgo for improved structure and readability#5512
test(injector): refactor tests to use Ginkgo for improved structure and readability#5512adity1raut wants to merge 1 commit intofluid-cloudnative:masterfrom
Conversation
Summary of ChangesHello @adity1raut, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the unit tests for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @adity1raut. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the injector tests to use the Ginkgo framework, which significantly improves the structure and readability of the tests as intended. The new structure using Describe, Context, and BeforeEach is much clearer than the previous test implementation.
I have a couple of suggestions to further improve the maintainability of the new test code by reducing some redundancy and duplication in the test setup.
| BeforeEach(func() { | ||
| objs := []runtime.Object{} | ||
| s := runtime.NewScheme() | ||
| Expect(corev1.AddToScheme(s)).To(Succeed()) | ||
| Expect(datav1alpha1.AddToScheme(s)).To(Succeed()) | ||
| Expect(appsv1.AddToScheme(s)).To(Succeed()) | ||
|
|
||
| fakeClient = fake.NewFakeClientWithScheme(s, objs...) | ||
| injector = NewInjector(fakeClient) | ||
| runtimeInfos = make(map[string]base.RuntimeInfoInterface) | ||
| }) |
There was a problem hiding this comment.
This BeforeEach block is largely redundant. The fakeClient and injector variables are re-initialized in the nested BeforeEach block (lines 217-224), and runtimeInfos could also be initialized there. To improve readability and reduce redundancy, consider removing this block and moving the variable declarations and necessary initializations into the Context block below.
| s := runtime.NewScheme() | ||
| Expect(corev1.AddToScheme(s)).To(Succeed()) | ||
| Expect(datav1alpha1.AddToScheme(s)).To(Succeed()) | ||
| Expect(appsv1.AddToScheme(s)).To(Succeed()) |
There was a problem hiding this comment.
This block of code for creating and setting up the runtime scheme is duplicated in multiple BeforeEach blocks (see also lines 53-56, 256-259, and 331-334). To follow the DRY (Don't Repeat Yourself) principle and improve maintainability, consider extracting this logic into a shared helper function.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
==========================================
- Coverage 60.04% 60.03% -0.01%
==========================================
Files 444 444
Lines 30540 30540
==========================================
- Hits 18339 18336 -3
- Misses 10685 10687 +2
- Partials 1516 1517 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cc @cheyang @TrafalgarZZZ PTAL |
|
@adity1raut: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only fluid-cloudnative members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm cancel |
Signed-off-by: adity1raut <araut7798@gmail.com>
adity1raut
force-pushed
the
TestingFuse4
branch
from
ca28177 to
b6bc0c4
Compare
|
2 participants
…nd readability
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Part of #5407
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews