output windows: check shorter service timeout on shutdown#5286
Open
kenhys wants to merge 1 commit intofluent:masterfrom
Open
output windows: check shorter service timeout on shutdown#5286kenhys wants to merge 1 commit intofluent:masterfrom
kenhys wants to merge 1 commit intofluent:masterfrom
Conversation
kenhys
force-pushed
the
win-warn-flush-at-shutdown
branch
4 times, most recently
from
89b929c to
b6131c2
Compare
When flush_at_shutdown was enabled, there is a case that buffer flush process takes longer time to be done. In such a case, if service timeout is too short, the fluentd process will be shutting down forcibly. This commit warn in specific environment. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
win-warn-flush-at-shutdown
branch
from
b6131c2 to
1b7eeb5
Compare
Contributor
Author
|
improved warning message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
When flush_at_shutdown was enabled, there is a case that buffer flush process takes longer time to be done. In such a case, if service timeout is too short, the fluentd process will be shutting down forcibly.
This commit warn in specific environment.
Docs Changes:
N/A
Release Note:
N/A