Skip to content

Fix for custom domain on GitHub Pages#437

Closed
kenhys wants to merge 1 commit intofluent:masterfrom
kenhys:fix-for-customdomain
Closed

Fix for custom domain on GitHub Pages#437
kenhys wants to merge 1 commit intofluent:masterfrom
kenhys:fix-for-customdomain

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 28, 2026

Followup #435 #436

In the previous version, set http_prefix to access
navigation links in https://fluent.github.io/fluentd-website.

When enabling custom domain on GitHub Pages, no need to
tweak http_prefix.

@kenhys kenhys marked this pull request as draft January 28, 2026 02:28
@kenhys
Copy link
Contributor Author

kenhys commented Jan 28, 2026

should rebase against #435

@kenhys kenhys force-pushed the fix-for-customdomain branch from c32e1b7 to 5c8e2f8 Compare January 28, 2026 03:04
@kenhys kenhys marked this pull request as ready for review January 28, 2026 03:23
@kenhys kenhys marked this pull request as draft January 28, 2026 03:27
@kenhys
Copy link
Contributor Author

kenhys commented Jan 28, 2026

#436 and #438 should be merged in advance.

@kenhys kenhys force-pushed the fix-for-customdomain branch from 5c8e2f8 to c771226 Compare January 28, 2026 06:34
In the previous version, set http_prefix to access
navigation links in https://fluent.github.io/fluentd-website.

When enabling custom domain on GitHub Pages, no need to
tweak http_prefix.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys force-pushed the fix-for-customdomain branch from c771226 to d1e10c1 Compare January 29, 2026 07:50
@kenhys
Copy link
Contributor Author

kenhys commented Jan 29, 2026

When we could make an agreement to switch GH with CNCF, then merge this PR and enable custom domain.

@kenhys
Copy link
Contributor Author

kenhys commented Jan 30, 2026

NOTE: when providing GitHub pages as backend, no need to apply this PR.
directly publish or deploy as backend is not determined yet.

@kenhys kenhys closed this Feb 4, 2026
@kenhys kenhys deleted the fix-for-customdomain branch February 4, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant