Skip to content

Conversation

@eschabell
Copy link
Contributor

@eschabell eschabell commented Jan 27, 2026

  • watcher_interval: interval to check symbolic link rotation
  • progress_check_interval: interval to check for pending data in monitored files (inotify mode)
  • progress_check_interval_nsec: nanosecond component of progress check interval

Fixes #11403


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [ N/A ] Example configuration file for the change
  • [ N/A ] Debug log output from testing the change
  • [ N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ N/A ] Run local packaging test showing all targets (including any new ones) build.
  • [ N/A ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ No] Documentation required for this feature

Note: already documented features.

Backporting

  • [ N/A ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Documentation
    • Enhanced inline descriptions for configuration options related to file rotation monitoring and data detection intervals, improving clarity for users configuring these settings.

✏️ Tip: You can customize this high-level summary in your review settings.

  - watcher_interval: interval to check symbolic link rotation
  - progress_check_interval: interval to check for pending data in
    monitored files (inotify mode)
  - progress_check_interval_nsec: nanosecond component of progress
    check interval

Fixes fluent#11403

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

Added inline description strings for three missing configuration parameters in the in_tail plugin: watcher_interval, progress_check_interval, and progress_check_interval_nsec. These descriptions clarify the purpose and behavior of each configuration option with no changes to functional logic.

Changes

Cohort / File(s) Summary
Configuration parameter documentation
plugins/in_tail/tail.c
Added inline description strings for three config entries: watcher_interval (interval to check rotated symbolic link files), progress_check_interval (interval to detect pending data using inotify), and progress_check_interval_nsec (nanosecond component clarification)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

docs-required

Suggested reviewers

  • edsiper
  • cosmo0920
  • patrick-stephens

Poem

🐰 Three descriptions lost, now found,
For watcher and progress all around,
In tail we hop with glee,
Documentation's wild and free! 📝✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding missing descriptions for three in_tail configuration parameters.
Linked Issues check ✅ Passed The PR adds descriptions for all three configuration parameters (watcher_interval, progress_check_interval, progress_check_interval_nsec) as required by issue #11403.
Out of Scope Changes check ✅ Passed All changes are directly related to adding missing parameter descriptions in the in_tail plugin configuration map; no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in_tail: missing three config parameter descriptions

1 participant