docs: outputs: aws plugins adding description of EUSC and China region endpoint handling#2507
Conversation
…ndling Applies to fluent#2499 Signed-off-by: Eric D. Schabell <eric@schabell.org>
…ling
Applies to fluent#2499
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applies to fluent#2499 Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applies to fluent#2499 Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughDocumentation updates to four AWS output plugins expand Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/outputs/s3.md (1)
77-77: Prefereusc-*wording to avoid under-documenting EUSC support.Line 77 currently names only
eusc-de-east-1. Since the behavior is pattern-based for EUSC regions, consider wording it aseusc-*(witheusc-de-east-1as an example) to prevent the docs from implying single-region support.Suggested wording
-| `region` | The AWS region of your S3 bucket. China regions (`cn-north-1`, `cn-northwest-1`) and the AWS European Sovereign Cloud region (`eusc-de-east-1`) are supported; Fluent Bit automatically uses the correct endpoint suffix (`.amazonaws.com.cn` or `.amazonaws.eu`) and no custom `endpoint` is required. | `us-east-1` | +| `region` | The AWS region of your S3 bucket. China regions (`cn-north-1`, `cn-northwest-1`) and AWS European Sovereign Cloud regions (`eusc-*`, for example `eusc-de-east-1`) are supported; Fluent Bit automatically uses the correct endpoint suffix (`.amazonaws.com.cn` or `.amazonaws.eu`) and no custom `endpoint` is required. | `us-east-1` |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/outputs/s3.md` at line 77, Update the region wording in the S3 output docs: replace the single-region mention `eusc-de-east-1` with pattern-style `eusc-*` and keep `eusc-de-east-1` as an example (e.g., "eusc-* (for example, eusc-de-east-1)") so the `region` table entry and the text that currently references `eusc-de-east-1` reflect EUSC-wide support; search for the `region` table cell and the literal `eusc-de-east-1` in the s3.md content to make the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/outputs/s3.md`:
- Line 77: Update the region wording in the S3 output docs: replace the
single-region mention `eusc-de-east-1` with pattern-style `eusc-*` and keep
`eusc-de-east-1` as an example (e.g., "eusc-* (for example, eusc-de-east-1)") so
the `region` table entry and the text that currently references `eusc-de-east-1`
reflect EUSC-wide support; search for the `region` table cell and the literal
`eusc-de-east-1` in the s3.md content to make the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9da96d6d-9028-45a0-b4bd-a0d3fa086125
📒 Files selected for processing (4)
pipeline/outputs/cloudwatch.mdpipeline/outputs/firehose.mdpipeline/outputs/kinesis.mdpipeline/outputs/s3.md
|
@patrick-stephens ready for review! |
The following plugins update the
regionconfiguration param description:pipeline/outputs/cloudwatch.md
pipeline/outputs/firehose.md
pipeline/outputs/kinesis.md
pipeline/outputs/s3.md
Fixes #2499
Summary by CodeRabbit
cn-north-1,cn-northwest-1) and AWS European Sovereign Cloud region (eusc-de-east-1).