docs: inputs: splunk: add add_remote_addr and remote_addr_key parameters#2503
Conversation
- Add add_remote_addr and remote_addr_key config parameters to the table
- Add "Add a remote address field" usage section with YAML and
classic .conf configuration examples
Fixes fluent#2494
Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughDocumentation for the Splunk input plugin is enhanced with two new configuration parameters: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/inputs/splunk.md (1)
124-125: Consider adding a trust-boundary note forX-Forwarded-For.Recommend clarifying that
X-Forwarded-Forshould be relied on only when traffic comes through trusted proxies/load balancers, to avoid spoofed client IP assumptions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/splunk.md` around lines 124 - 125, Add a trust-boundary note to the documentation for add_remote_addr explaining that X-Forwarded-For can be spoofed and must only be trusted when traffic is routed through known/trusted proxies or load balancers; update the paragraph mentioning add_remote_addr, remote_addr_key and X-Forwarded-For to explicitly state that the header should be used only in controlled proxy environments and recommend validating or configuring trusted proxy IPs (or falling back to connection address) to avoid assuming client IPs from untrusted sources.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/inputs/splunk.md`:
- Around line 124-125: Add a trust-boundary note to the documentation for
add_remote_addr explaining that X-Forwarded-For can be spoofed and must only be
trusted when traffic is routed through known/trusted proxies or load balancers;
update the paragraph mentioning add_remote_addr, remote_addr_key and
X-Forwarded-For to explicitly state that the header should be used only in
controlled proxy environments and recommend validating or configuring trusted
proxy IPs (or falling back to connection address) to avoid assuming client IPs
from untrusted sources.
|
@patrick-stephens ready for review! |
Fixes #2494
Summary by CodeRabbit
Release Notes
New Features
add_remote_addrandremote_addr_keyconfiguration parameters to customize remote address field inclusion and naming.Documentation