-
Notifications
You must be signed in to change notification settings - Fork 0
FDN-4209 Update pr-validator workflow #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughA new GitHub Actions workflow is introduced to validate pull request titles against a Jira-like pattern. The workflow triggers on pull request events and uses a script to enforce that PR titles begin with at least three uppercase letters, followed by a hyphen and a 3- to 6-digit number. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a GitHub Actions workflow to enforce JIRA ticket references in pull request titles. The workflow validates that PR titles begin with a properly formatted JIRA ticket identifier.
- Adds automated PR validation for JIRA ticket format compliance
- Implements regex-based validation requiring 3+ uppercase letters, followed by 3-6 digit numbers (excluding all-zero patterns)
- Configured to run on PR open, edit, and synchronize events
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pr-validator.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/pr-validator.yml
11-11: the runner of "actions/github-script@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Jenkins
🔇 Additional comments (2)
.github/workflows/pr-validator.yml (2)
1-4: LGTM: Workflow triggers are appropriately configured.The event types (opened, edited, synchronize) correctly capture scenarios where PR validation should run: new PRs, title/description edits, and new commits.
14-36: LGTM: PR title validation logic is sound.The regex pattern correctly enforces the JIRA ticket format (3+ uppercase letters, hyphen, 3–6 digits, excluding all-zero numbers), and the error message provides clear guidance to developers. The use of
core.setFailed()ensures workflow failure on invalid titles.
mikeclimbrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolves FDN-4209
This PR adds the pr-validator workflow to ensure PRs have associated JIRA tickets.
Summary by CodeRabbit