Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 3 additions & 2 deletions .nix/pkgs/flow-php/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
with-blackfire ? false,
with-pg-query-ext ? false,
with-arrow-ext ? false,
with-grpc ? false
with-grpc ? false,
with-protobuf ? true
}:

let
Expand All @@ -27,7 +28,6 @@ let
(php-lz4.override { inherit php; })
(php-snappy.override { inherit php; })
(php-zstd.override { inherit php; })
protobuf
xmlreader
xmlwriter
zlib
Expand All @@ -38,6 +38,7 @@ let
++ (if with-pg-query-ext then [(php-pg-query-ext.override { inherit php; })] else [])
++ (if with-arrow-ext then [(php-arrow-ext.override { inherit php; })] else [])
++ (if with-grpc then [grpc] else [])
++ (if with-protobuf then [protobuf] else [])
);
in
flowPHP.buildEnv {
Expand Down
2 changes: 2 additions & 0 deletions .php-cs-fixer.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
])
->exclude([
'Flow/Parquet/ThriftModel',
'Opentelemetry',
'GPBMetadata',
'Flow/CLI/Tests/Integration',
'Flow/ETL/Tests/Unit/Loader',
'Flow/ETL/Tests/Unit/Exception',
Expand Down
2 changes: 1 addition & 1 deletion compose.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ services:
- "8888:8888"
volumes:
- "./docker/otel-collector-config.yaml:/etc/otel-collector-config.yaml:ro"
- "./var/otel:/var/otel"
- "./.scratchpad/migraitons/var/otel:/var/otel"
depends_on:
- aspire
- postgres
Expand Down
10 changes: 9 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
"grpc/grpc": "^1.74",
"nikic/php-parser": "^5.3",
"nyholm/psr7": "^1.8",
"open-telemetry/gen-otlp-protobuf": "^1.8",
"php-http/curl-client": "^2.2",
"php-http/mock-client": "^1.5",
"ramsey/uuid": "^4.5",
Expand Down Expand Up @@ -187,6 +186,12 @@
],
"Flow\\ETL\\Adapter\\Doctrine\\": [
"src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine"
],
"Opentelemetry\\Proto\\": [
"src/bridge/telemetry/otlp/src/Opentelemetry/Proto"
],
"GPBMetadata\\Opentelemetry\\": [
"src/bridge/telemetry/otlp/src/GPBMetadata/Opentelemetry"
]
},
"files": [
Expand Down Expand Up @@ -428,6 +433,9 @@
"protoc --php_out=src/lib/postgresql/src --proto_path=src/lib/postgresql/resources/proto pg_query.proto",
"@cs:php:fix"
],
"build:telemetry:otlp:protobuf": [
"src/bridge/telemetry/otlp/bin/generate-proto.sh"
],
"pre-autoload-dump": [
"Google\\Task\\Composer::cleanup"
],
Expand Down
81 changes: 9 additions & 72 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions docker/otel-collector-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ receivers:
http:
endpoint: 0.0.0.0:4318

# OTLP JSON file receiver — picks up JSONL written by flow-php StreamTransport.
# Docs: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/otlpjsonfilereceiver
otlpjsonfile:
include:
- /var/otel/*.jsonl
start_at: end

# PostgreSQL metrics receiver
# Docs: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/postgresqlreceiver
postgresql:
Expand Down Expand Up @@ -138,3 +145,6 @@ service:
logs:
receivers: [otlp]
exporters: [debug, otlp_grpc/aspire]
logs/file:
receivers: [otlpjsonfile]
exporters: [debug, otlp_grpc/aspire]
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ use function Flow\Telemetry\DSL\{
use function Flow\Bridge\Telemetry\OTLP\DSL\{
otlp_curl_transport,
otlp_json_serializer,
otlp_log_exporter,
otlp_exporter,
};
use function Flow\Bridge\Monolog\Telemetry\DSL\telemetry_handler;

Expand All @@ -305,7 +305,7 @@ $transport = otlp_curl_transport(
$telemetry = telemetry(
$resource,
loggerProvider: logger_provider(
batching_log_processor(otlp_log_exporter($transport))
batching_log_processor(otlp_exporter($transport))
),
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ Add the extension to your `phpunit.xml.dist`:

### gRPC transport (`transport=grpc`)

Requires the `grpc` PHP extension and the `google/protobuf` + `open-telemetry/gen-otlp-protobuf` packages. Payload is
always protobuf (per OTLP/gRPC spec).
Requires the `grpc` PHP extension and the `google/protobuf` package. Payload is always protobuf (per OTLP/gRPC spec).

| Parameter | Environment variable | Default | Description |
|-----------------|-----------------------------------|---------|----------------------------------|
Expand Down
Loading
Loading