Skip to content

Conversation

@sleepybishop
Copy link
Contributor

Hello, I had trouble with the control page reflecting the correct power status of the unit. It would appear the power variable is being sent as a string (ON|OFF) but the template is expecting a boolean. This pr corrects the behavior to be consistent with the output in the metrics template.

@floatplane
Copy link
Owner

thank you for the catch! I'll wait for the checks to finish and then merge

@floatplane
Copy link
Owner

looks like we'll need to rebase this once I get the other PR merged 😄

@sleepybishop
Copy link
Contributor Author

pulled in #82 and cppcheck fix here

@floatplane
Copy link
Owner

sorry for my resposne lag here, I'm on vacation for a couple of days 🏖️. running the checks now

@floatplane
Copy link
Owner

I am trying to fix the check config once and for all in #83, have to step away from the keyboard now while that builds. Thanks for your patience 🙏

@floatplane
Copy link
Owner

Ok @sleepybishop, main should be in a good state for you to build on. in #83 I cherry-picked your change to update ESPAsyncWebserver, and then got the config for cppcheck and clang-tidy updated to work on all platforms.

I think if you rebase this PR on main and only keep dd545fc then it should build fine!

Thanks again for your patience 😄

@sleepybishop
Copy link
Contributor Author

Sorry for all the trouble my simple change caused you. I've done as you suggested and rebased to only keep the relevant commit.

@floatplane
Copy link
Owner

please don't apologize @sleepybishop! I'm sorry you were the one who stumbled on the hidden brokenness here. thanks for the fix and thanks for your patience!

@floatplane floatplane merged commit abb2ddd into floatplane:main Feb 5, 2025
14 checks passed
@sleepybishop sleepybishop deleted the power_template_bool branch February 5, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants