feat: show unread counts#1343
Conversation
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @mavonx! Please fix the following issues with your PR:
- Title: Is too long (45 characters). The PR title must be strictly under 40 characters.
Formatting issues have been resolved. Thank you!
|
I've implemented the unread counters feature for the I also wanted to note that when folder names are initially loaded from the cache, there will be a delay before the counters display correctly once the server fetch completes. To remove this delay, I thought about storing the unread counter alongside each folder in Let me know if you have a different approach to handle this. |
|
i'd cache this and load it from |
|
I already decrease the unread count from the selected folder in memory. But just to make sure: if I load the counters from the cache and don't update the cached counters after each unread email is marked as read, then the counters will only stay correct while the user is in the same process/session, but if the user closes the current session and opens it again, they will see the outdated counter from the cache until the server fetch corrects it. So, is that okay? |
|
you should update the cache when an email is read (opened). when matcha is re-fetching it should also update the counter |
|
@andrinoff I'll check the tests tomorrow. |
What?
Shows unread email counts next to folder names in the sidebar.
Why?
Folder list showed folder names only, making it impossible to see which folders have unread mail without opening each one.
This improves navigation efficiency.
Closes #645