Skip to content

fix: add ok checks to type assertions in HTTP plugin tests #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MD-Mushfiqur123 wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −3
Open

fix: add ok checks to type assertions in HTTP plugin tests #1338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions plugin/http_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,22 @@ func TestHTTPGet(t *testing.T) {
t.Fatalf("expected table, got %T", res)
}

if status := tbl.RawGetString("status"); status.(lua.LNumber) != 200 {
status, ok := tbl.RawGetString("status").(lua.LNumber)
if !ok {
t.Fatalf("expected status to be LNumber, got %T", tbl.RawGetString("status"))
}
if status != 200 {
t.Errorf("expected status 200, got %v", status)
}
if body := tbl.RawGetString("body"); body.String() != "ok" {
t.Errorf("expected body 'ok', got %q", body.String())
}

headers := tbl.RawGetString("headers").(*lua.LTable)
headersVal := tbl.RawGetString("headers")
headers, ok := headersVal.(*lua.LTable)
if !ok {
t.Fatalf("expected headers to be LTable, got %T", headersVal)
}
if v := headers.RawGetString("x-test"); v.String() != "hello" {
t.Errorf("expected header x-test='hello', got %q", v.String())
}
Expand Down Expand Up @@ -96,7 +104,10 @@ func TestHTTPPostWithBodyAndHeaders(t *testing.T) {
}

res := m.state.GetGlobal("res")
tbl := res.(*lua.LTable)
tbl, ok := res.(*lua.LTable)
if !ok {
t.Fatalf("expected table, got %T", res)
}
if body := tbl.RawGetString("body"); body.String() != `{"key":"value"}` {
t.Errorf("expected echoed body, got %q", body.String())
}
Expand Down
Loading