Skip to content

fix: check file Close() error in update asset download #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MD-Mushfiqur123 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix: check file Close() error in update asset download #1336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3760,10 +3760,13 @@ func runUpdateCLI() (err error) {
return fmt.Errorf("could not create temp file: %w", err)
}
_, err = io.Copy(outFile, respAsset.Body)
outFile.Close()
if err != nil {
outFile.Close()
return fmt.Errorf("could not write asset to disk: %w", err)
}
if err := outFile.Close(); err != nil {
return fmt.Errorf("could not finalize asset file: %w", err)
}

// Determine the expected binary name based on the OS.
binaryName := "matcha"
Expand Down
Loading