fix(sender): fold References header#1323
Closed
resolvicomai wants to merge 1 commit into
Closed
Conversation
floatpanebot
added
area/sender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fold
Referencesheader values at RFC 5322 recommended line length, and reuse the formatter for regular email and calendar replies. Very long reference chains now keep the root reference and newest reply context while trimming older middle IDs to stay under the hard line limit.Why?
Closes #1115. A deep reply thread could emit one oversized
Referencesline, which some MTAs reject or truncate. Added sender tests for folding and middle trimming.Tests:
go test ./sender;go test ./...;git diff --check