docs(v2): add use_pkce config for GitHub auth and document OIDC nonce field#406
Conversation
… field Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
PR ReviewOverview This is a small, focused docs-only PR that closes #403. It does two things:
What looks good
Suggestions1. OIDC description clarity The updated OIDC description reads:
PKCE (code verifier/challenge) and an OIDC nonce are two distinct security mechanisms. Combining them in a single sentence for a single config field (
The referenced upstream PR title ("fix(authn): oauth pkce challenge for github and a correct oidc nonce") suggests the nonce behavior is tied to this option, but the docs should make that relationship clear to readers. 2. Consistency between the two descriptions The OIDC and GitHub entries describe the same conceptual option but with different phrasing:
Unless the OIDC version intentionally does something extra (the nonce), aligning these would make the table easier to scan. No blockersThe change is correct and safe to merge as-is. The suggestions above are minor readability improvements, not required fixes. |
closes #403