-
Notifications
You must be signed in to change notification settings - Fork 19
docs: add license command documentation and improve CLI command structure #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ture - Add documentation for new `license check` and `license activate` commands - Structure license commands as subcommands (like config init/edit) - Update quickstart command docs to describe new TUI features - Add synopsis sections to all CLI commands for consistency - Standardize command documentation order: Synopsis → Options → Examples - Add license command references to licensing documentation - Include quickstart command reference in quickstart guide Fixes #369 Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Pull Request ReviewI've reviewed PR #370 and overall this is excellent work! The documentation additions are well-structured, consistent, and follow the project's style guidelines. Here's my detailed feedback: ✅ StrengthsDocumentation Quality
Structural Improvements
Writing Style
📝 Minor Suggestions1. License Command Descriptions (docs/v2/cli/commands/license/check.mdx & activate.mdx)The descriptions use consistent formatting with bullet lists, which is great. However, consider these minor improvements: In ## Synopsis
Validates your current license configuration and displays license status information.
Use this command to verify your license is properly configured before deploying to production, or to troubleshoot licensing issues.
The `check` command:In ## Synopsis
Interactive wizard for activating a new Flipt Pro license.
Run this command when you first receive a license key or need to update your license configuration.
The `activate` command provides a guided, text-based user interface that:2. Code Block Formatting ConsistencyIn flipt evaluate chat-enabled --context test=foo
{"flag_key":"chat-enabled",...}This is fine if the output appears on a separate line, but verify this matches the actual command output. 3. Migration Command Note PlacementIn ## Synopsis
<Note>
This currently only supports Clickhouse analytics database migrations.
</Note>
Runs pending analytics database migrations.This gives users the important limitation upfront. 4. Link Text in licensing.mdxIn - [`flipt license check`](/v2/cli/commands/license/check): Validate your current license and view available Pro features
- [`flipt license activate`](/v2/cli/commands/license/activate): Interactive wizard to activate a new licenseThis is more of a stylistic preference, but consider removing the bold 🔍 Questions/Clarifications1. Screenshot TODOsThe PR description mentions "Screenshot placeholders have been added with TODO comments" for license check output and activation wizard. I don't see these TODO comments in the diff. Were they added in a different way, or should they be added to the MDX files? If they need to be added, consider using HTML comments that won't render: <!-- TODO: Add screenshot of license check output -->
<!-- TODO: Add screenshot of license activation wizard -->2. Offline License ValidationIn 3. More Info LinksIn the new license command docs, the "More Info" section links to both 🎯 Testing RecommendationsBefore merging, please verify:
📊 Overall AssessmentApproval: ✅ Recommended for merge (after addressing minor suggestions) This PR significantly improves the CLI documentation structure and adds valuable content for Pro license management. The changes are well-implemented, consistent with existing patterns, and follow the project's guidelines as outlined in CLAUDE.md. Impact: High value - provides clear guidance for Pro users while improving overall CLI documentation consistency. Risk: Low - documentation-only changes with no code modifications. Great work on this comprehensive documentation update! 🎉 |
|
@claude help me address the minor inconsistencies either on this branch or another one based off of this branch |
|
Claude finished @markphelps's task in 2m 11s —— View job Addressing Minor Inconsistencies ✅I've successfully addressed the minor suggestions from my previous review on this branch. Changes Made
Tasks Completed
Notes on LintingI don't have permissions to run CommitChanges committed and pushed to branch
--- | |
- Add contextual usage guidance to license command synopses - Move Note before description in migrate.mdx for better visibility - Remove redundant bold formatting from licensing.mdx command links - Add TODO comments for screenshot placeholders Co-authored-by: Mark Phelps <markphelps@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Summary
license checkandlicense activatecommandsChanges
New Documentation
docs/v2/cli/commands/license/check.mdx- documentation for checking license statusdocs/v2/cli/commands/license/activate.mdx- documentation for activating licensesUpdated Documentation
docs/v2/cli/commands/quickstart.mdx- added details about new TUI interfacedocs/v2/licensing.mdx- added references to license CLI commandsdocs/v2/quickstart.mdx- added tip about quickstart commandNavigation
docs/docs.jsonto include license command group with subcommandsNotes
Screenshot placeholders have been added with TODO comments for the following:
Fixes #369