Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ RUN apt-get install -y \
libostree-dev \
fakemachine

RUN apt-get install -y systemd-container

RUN apt-get install -y parted

RUN apt-get install -y e2fsprogs util-linux

Comment on lines +58 to +63
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add these packages to the existing list instead? Each RUN command creates a separate layer in Docker, and each apt-get call recalculates dependencies, making the build slower

RUN go install -v github.com/go-debos/debos/cmd/debos@latest

RUN install -m 755 ~/go/bin/debos /usr/local/bin
Expand All @@ -66,9 +72,11 @@ RUN install -m 755 ~/.cargo/bin/zeekstd /usr/local/bin/
# Clean up apt cache to reduce image size
RUN apt-get clean && rm -rf /var/lib/apt/lists/* ~/.cargo ~/go

# Clone the rk3576-linux-build repository
# Copy the rk3576-linux-build folder
WORKDIR /rk3576-linux-build
RUN git clone --depth=1 https://github.com/flipperdevices/rk3576-linux-build .
COPY . /rk3576-linux-build

RUN ln -s /artifacts /rk3576-linux-build/artifacts
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain in more detail why this one is needed? I can't see why are we creating a subdirectory and then creating workarounds to help with the fact that all the stuff is suddenly inside a subdirectory :)


# Entry point
ENTRYPOINT ./build-uboot.sh && ./build-kernel-mainline.sh && ./build-kernel-bsp.sh && ./build-images.sh