Skip to content

fix(ui): align mobile nav menu items with divider lines #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielnaab merged 9 commits into from
May 7, 2026
+21 −15
Merged

fix(ui): align mobile nav menu items with divider lines #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee8ffeb
fix(ui): align mobile nav menu items with divider lines
danielnaab May 7, 2026
3605de4
fix(ui): position close button absolutely so nav items start at top
danielnaab May 7, 2026
d907398
fix(ui): keep close button in flow, fix user section indentation
danielnaab May 7, 2026
715ac8d
fix(ui): mobile nav vertical position and horizontal alignment
danielnaab May 7, 2026
49abdca
fix(ui): mobile nav items too low, text misaligned with borders
danielnaab May 7, 2026
bdbb4ac
fix(ui): convert mobile nav from hardcoded rem to px/tokens
danielnaab May 7, 2026
7467b66
fix(ui): rewrite mobile nav layout from flex to block, rem to px
danielnaab May 7, 2026
8eaeddc
fix(ui): use spacing token for nav link padding
danielnaab May 7, 2026
d0e197b
style(auth): fix import ordering
danielnaab May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions src/design-system/components/flex-header/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,42 +345,48 @@ flex-header {

.flex-header__nav {
position: fixed;
inset-inline-end: 0;
inset-block-end: 0;
inset-block-start: 0;
right: 0;
top: 0;
bottom: 0;
background: var(--flex-color-surface);
border-inline-end: 0;
display: none;
flex-direction: column;
justify-content: flex-start;
overflow-y: auto;
padding: 1rem;
inline-size: 15rem;
padding: var(--flex-space-md);
inline-size: 240px;
z-index: 500;

&.is-visible {
display: flex;
display: block;
animation: flex-header-slidein 0.3s ease-in-out;
}
}

.flex-header__close-btn {
display: block;
block-size: 48px;
inline-size: 48px;
}

.flex-header__nav-list {
flex-direction: column;
align-items: stretch;
inline-size: 100%;
display: block;
list-style: none;
margin: 0;
padding: 0;
}

.flex-header__nav-item {
border-block-start: 1px solid var(--flex-color-border);
}

.flex-header__nav-item:first-child {
border-block-start: 0;
}

.flex-header__nav-link {
padding-block: 0.75rem;
padding-inline: 1rem;
display: block;
block-size: auto;
padding: var(--flex-space-sm) 0;
}

.flex-header__nav-link--current::after,
Expand Down Expand Up @@ -448,7 +454,7 @@ flex-header {

@keyframes flex-header-slidein {
0% {
transform: translateX(15rem);
transform: translateX(240px);
}

100% {
Expand Down
2 changes: 1 addition & 1 deletion src/entrypoints/app/routes/auth/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Hono } from 'hono'
import { deleteCookie, setCookie } from 'hono/cookie'
import type { ActivityStore } from '../../../../services/activity'
import { Layout } from '../../../../design-system/components/flex-layout'
import type { ActivityStore } from '../../../../services/activity'
import type { AccessStore, UserStore } from '../../../../services/auth'
import {
COOKIE_MAX_AGE,
Expand Down
Loading