Fix duplicate slash URL handling for 25.9#2052
Open
benflexcompute wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v25.9.9/25.9.9for release.Verification
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=/tmp/Flow360-25.9 /disk2/ben/Flow360/.venv/bin/python -m pytest tests/test_environment.py tests/test_current_flow360_version.py tests/simulation/test_updater.py -q -p no:cacheproviderrequests==2.34.2: prod and preprod folder requests used single-slash URLs andRestApi.getsucceeded.Note:
poetry check --lockstill fails on the existing unrelatedpyswarmsdocs extra issue, but no longer reports stale lock metadata.Note
Low Risk
Targeted URL joining and path string tweaks with regression tests; no auth or data-model changes.
Overview
This release fixes API URL construction so folder and item calls no longer produce paths with double slashes when environment base URLs end with
/and REST paths start with/.EnvironmentConfignow joins base URLs and paths by trimming extra slashes on both sides (get_real_url,get_portal_real_url,get_web_real_url). Folder code usesv2/itemsandv2/folderswithout a leading slash onRestApi.requestsis capped to the 2.32.x line, and the client is bumped to25.9.9with new tests for slash normalization andRestApipaths.Reviewed by Cursor Bugbot for commit 2122477. Bugbot is set up for automated code reviews on this repo. Configure here.