Fix duplicate slash URL handling for 25.8#2051
Open
benflexcompute wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
PYTHONDONTWRITEBYTECODE=1 /disk2/ben/Flow360/.venv/bin/python -m pytest tests/test_environment.py -q -p no:cacheproviderrequests==2.34.2: prod and preprod folder requests used single-slash URLs andRestApi.getsucceeded.Note:
poetry check --lockstill fails on the existing unrelatedpyswarmsdocs extra issue, but no longer reports stale lock metadata.Note
Medium Risk
Touches how all REST URLs are built and folder API paths; wrong joining could break API calls, though behavior is covered by new tests.
Overview
Fixes double-slash API URLs when environment base URLs end with
/and REST paths start with/(or the opposite).EnvironmentConfigURL helpers now join bases and paths with normalized slashes; folder listing code usesv2/itemsandv2/folderswithout a leading slash.requestsis capped to the 2.32 patch line (>=2.32.4,<2.33.0) with an updated lockfile. New tests cover slash normalization for environment URLs andRestApipaths.Reviewed by Cursor Bugbot for commit b50a532. Bugbot is set up for automated code reviews on this repo. Configure here.