Skip to content

Conversation

@piotrkluba
Copy link
Collaborator

@piotrkluba piotrkluba commented Jan 15, 2026

Note

Ensures result models created from case files can access simulation params.

  • Set ._get_params_method on created MonitorCSVModel and UserDefinedDynamicsCSVModel instances in case_results.py
  • Add mock case files payload tests/data/mock_webapi/case_files_mock_response.json and wire route in tests/mock_server.py
  • Add test test_udd_monitors_get_params_method in tests/test_results.py asserting results.user_defined_dynamics[...] and results.monitors[...] expose _get_params_method()
  • Minor formatting fix to tests/data/mock_webapi/case_params_resp.json

Written by Cursor Bugbot for commit cc22458. This will update automatically on new commits. Configure here.

@benflexcompute
Copy link
Collaborator

benflexcompute commented Jan 15, 2026

Can you rebase and send this to 25.7 or 25.6 instead? Then there will be auto hotfix PRs by CI.

@piotrkluba piotrkluba enabled auto-merge (squash) January 15, 2026 15:16
@piotrkluba piotrkluba merged commit f6a9a0f into main Jan 15, 2026
21 checks passed
@piotrkluba piotrkluba deleted the piotr/fix-monitor-udd-results branch January 15, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants