-
Notifications
You must be signed in to change notification settings - Fork 607
Fix wrong LinearGradient alignment defaults + allow multiple use of --exclude option in flet build
#5986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes two bugs: incorrect LinearGradient alignment defaults that were calling non-existent methods instead of using class constants, and the inability to use the --exclude option multiple times in flet build commands. Additionally, it includes documentation formatting improvements across gradient classes.
- Fixed
LinearGradient.beginandLinearGradient.endto useAlignment.CENTER_LEFTandAlignment.CENTER_RIGHTconstants instead of method calls - Enabled multiple uses of
--excludeoption in build commands by addingaction="extend" - Improved documentation formatting with better cross-references and code formatting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/python/packages/flet/src/flet/controls/gradients.py | Fixes LinearGradient alignment defaults from method calls to property access, improves documentation formatting and cross-references |
| sdk/python/packages/flet-cli/src/flet_cli/commands/build_base.py | Adds action="extend" to --exclude argument to enable multiple uses and updates help text |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying flet-docs with
|
| Latest commit: |
730f70c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cbef1f30.flet-docs.pages.dev |
| Branch Preview URL: | https://fix-bugs.flet-docs.pages.dev |
Deploying flet-examples with
|
| Latest commit: |
730f70c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10445657.flet-examples.pages.dev |
| Branch Preview URL: | https://fix-bugs.flet-examples.pages.dev |
fix #5985
fix #5983
fix #5980
Summary by Sourcery
Fix gradient defaults and improve build CLI exclusion handling.
Bug Fixes:
Enhancements:
Build: