Skip to content

Conversation

@ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Jan 9, 2026

fix #5985
fix #5983
fix #5980

Summary by Sourcery

Fix gradient defaults and improve build CLI exclusion handling.

Bug Fixes:

  • Correct the default begin/end alignments for LinearGradient to match expected constants.
  • Allow the flet build --exclude option to be specified multiple times to accumulate excluded files and directories.

Enhancements:

  • Improve gradient-related docstrings and parameter references for LinearGradient, RadialGradient, and SweepGradient.

Build:

  • Update flet build CLI argument definition and help text for the --exclude option.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two bugs: incorrect LinearGradient alignment defaults that were calling non-existent methods instead of using class constants, and the inability to use the --exclude option multiple times in flet build commands. Additionally, it includes documentation formatting improvements across gradient classes.

  • Fixed LinearGradient.begin and LinearGradient.end to use Alignment.CENTER_LEFT and Alignment.CENTER_RIGHT constants instead of method calls
  • Enabled multiple uses of --exclude option in build commands by adding action="extend"
  • Improved documentation formatting with better cross-references and code formatting

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/python/packages/flet/src/flet/controls/gradients.py Fixes LinearGradient alignment defaults from method calls to property access, improves documentation formatting and cross-references
sdk/python/packages/flet-cli/src/flet_cli/commands/build_base.py Adds action="extend" to --exclude argument to enable multiple uses and updates help text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2026

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 730f70c
Status: ✅  Deploy successful!
Preview URL: https://cbef1f30.flet-docs.pages.dev
Branch Preview URL: https://fix-bugs.flet-docs.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

Deploying flet-examples with  Cloudflare Pages  Cloudflare Pages

Latest commit: 730f70c
Status: ✅  Deploy successful!
Preview URL: https://10445657.flet-examples.pages.dev
Branch Preview URL: https://fix-bugs.flet-examples.pages.dev

View logs

@FeodorFitsner FeodorFitsner merged commit 92f291e into main Jan 12, 2026
29 checks passed
@FeodorFitsner FeodorFitsner deleted the fix-bugs branch January 12, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants