Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "fleetbase/core-api",
"version": "1.6.45",
"version": "1.6.46",
"description": "Core Framework and Resources for Fleetbase API",
"keywords": [
"fleetbase",
Expand Down
26 changes: 22 additions & 4 deletions src/Models/User.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Fleetbase\Notifications\UserCreated;
use Fleetbase\Notifications\UserInvited;
use Fleetbase\Support\NotificationRegistry;
use Fleetbase\Support\Timezone;
use Fleetbase\Support\Utils;
use Fleetbase\Traits\ClearsHttpCache;
use Fleetbase\Traits\Expandable;
Expand Down Expand Up @@ -1220,7 +1221,14 @@ public function isNotVerified(): bool
*/
public static function applyUserInfoFromRequest($request, array $attributes = []): array
{
$info = null;
$info = null;
$timezone = Timezone::firstValid([
$request->input('timezone'),
$request->input('whois.timezone'),
$request->input('whois.time_zone.name'),
data_get($attributes, 'timezone'),
]);

// Lookup user default details
try {
$info = \Fleetbase\Support\Http::lookupIp($request);
Expand All @@ -1230,10 +1238,16 @@ public static function applyUserInfoFromRequest($request, array $attributes = []
if ($info) {
$attributes['country'] = data_get($info, 'country_code');
$attributes['ip_address'] = data_get($info, 'ip', $request->ip());
$tzInfo = data_get($info, 'time_zone.name', $request->input('timezone'));
if ($tzInfo) {
$attributes['timezone'] = $tzInfo;
$timezone = $timezone ?: Timezone::firstValid([
data_get($info, 'time_zone.name'),
data_get($info, 'timezone'),
data_get($info, 'timezone_name'),
]);

if ($timezone) {
$attributes['timezone'] = $timezone;
}

$attributes['meta'] = [
'areacode' => data_get($info, 'calling_code'),
'currency' => data_get($info, 'currency.code'),
Expand All @@ -1245,6 +1259,10 @@ public static function applyUserInfoFromRequest($request, array $attributes = []
];
}

if ($timezone) {
$attributes['timezone'] = $timezone;
}

return $attributes;
}

Expand Down
25 changes: 25 additions & 0 deletions src/Support/Timezone.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

namespace Fleetbase\Support;

class Timezone
{
/**
* Return the first valid IANA timezone from a list of candidates.
*/
public static function firstValid(array $candidates): ?string
{
foreach ($candidates as $candidate) {
if (!is_string($candidate) || trim($candidate) === '') {
continue;
}

$candidate = trim($candidate);
if (in_array($candidate, \DateTimeZone::listIdentifiers(), true)) {
return $candidate;
}
}

return null;
}
}
40 changes: 40 additions & 0 deletions tests/Unit/TimezoneTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<?php

use Fleetbase\Support\Timezone;

test('first valid timezone preserves request precedence order', function () {
$timezone = Timezone::firstValid([
'America/New_York',
'Asia/Singapore',
]);

expect($timezone)->toBe('America/New_York');
});

test('first valid timezone accepts nested whois timezone candidates', function () {
$timezone = Timezone::firstValid([
null,
'Europe/London',
'Asia/Singapore',
]);

expect($timezone)->toBe('Europe/London');
});

test('first valid timezone ignores invalid values', function () {
$timezone = Timezone::firstValid([
'Not/A_Timezone',
'Also/Invalid',
]);

expect($timezone)->toBeNull();
});

test('first valid timezone does not default to application timezone', function () {
$timezone = Timezone::firstValid([
null,
'',
]);

expect($timezone)->toBeNull();
});
Loading