enh(api): Add getServices endpoint and delegate container naming#51
Merged
enh(api): Add getServices endpoint and delegate container naming#51
Conversation
Code Review SummaryThe PR adds a new endpoint to fetch services for a deployment and updates the CronJobs UI to allow selecting these services instead of manual text entry. It also delegates container naming to the agent by removing hardcoded names in compose templates. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
nfebe
force-pushed
the
feat/container-name-resolution
branch
from
30c7f02 to
990a68a
Compare
Deploying flatrun-ui with
|
| Latest commit: |
4259b06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2003688c.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-container-name-resoluti.flatrun-ui.pages.dev |
Add deploymentsApi.getServices() for fetching deployment services. Export apiClient for reuse. Remove hardcoded container_name from compose templates. Replace free-text service input in CronJobsView with a dropdown populated from the deployment's real services, with loading indicator and service reset on deployment change. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/container-name-resolution
branch
from
990a68a to
4259b06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deploymentsApi.getServices() for fetching deployment services. Export apiClient for reuse across stores. Remove hardcoded container_name from compose templates since the agent's EnsureContainerNames handles this automatically.